-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selenium Service Migration to Docker Compose #3883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhadapaithankar
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
October 4, 2024 00:19
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-10902-selenium-service
branch
from
October 8, 2024 21:41
86205d3
to
4a00be0
Compare
/azp run ci, e2e |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run ci |
github-actions
bot
added
needs-rebase
branch needs a rebase
and removed
ready-for-review
labels
Oct 10, 2024
Please rebase pull request. |
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-10902-selenium-service
branch
from
October 10, 2024 19:26
af8ebd4
to
cb56540
Compare
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-10902-selenium-service
branch
from
October 10, 2024 19:29
cb56540
to
b13fec1
Compare
shubhadapaithankar
force-pushed
the
shubhadapaithankar/ARO-10902-selenium-service
branch
from
October 10, 2024 19:30
b13fec1
to
e839eb0
Compare
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
slawande2
previously approved these changes
Oct 10, 2024
tsatam
previously approved these changes
Oct 10, 2024
…h the original configuration
shubhadapaithankar
dismissed stale reviews from tsatam and slawande2
via
October 10, 2024 21:01
c6f0f93
tsatam
approved these changes
Oct 10, 2024
/azp run ci |
Azure Pipelines successfully started running 1 pipeline(s). |
slawande2
approved these changes
Oct 10, 2024
slawande2
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Selenium Service Migration to Docker Compose * Improved the consistency and readability of your code. * Remove unused build target, switch to standalone-chrome, and update scripts for consistency * fix(docker-compose): revert to using selenium/standalone-edge * Changed the image to selenium/standalone-edge:4.10.0-20230607 to match the original configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes: ARO-10902
What this PR does / why we need it:
This PR migrates the Selenium service to Docker Compose, ensuring it runs in an isolated container with proper health checks. It simplifies the process of running Selenium for automated browser testing as part of the CI/CD pipeline. This also improves the maintainability of the infrastructure by consolidating service management into Docker Compose.
Test plan for issue:
This PR was tested by running the Docker Compose setup locally to validate the Selenium service operates correctly and responds on
localhost:4444.
Health checks are configured to ensure proper functionality. Additionally, integration tests were executed to verify that Selenium can interact with the system as expected.Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?