Fix subscription ID of armRPPrivateLinkServices client #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitoku
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam and
fahlmant
as code owners
bitoku
force-pushed
the
fix/subscription
branch
from
4af4555
to
80e1216
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
slawande2
pushed a commit
that referenced
this pull request
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes N/A
What this PR does / why we need it:
This PR fixes InvalidAuthenticationTokenTenant in Prod.
The old client used
_env.SubscriptionID()(see L262 and L264 on the left pane in https://github.com/Azure/ARO-RP/pull/3616/files#diff-f4933755bd63c9e160a2068e8ccb4048e8df1b43f7f4544dcbc7ae2650a07478), but the new client usesr.SubscriptionID, which caused the subscription mismatch and caused the InvalidAuthenticationTokenTenant error.This PR fixes the subscription for
armRPPrivateLinkServicesandarmFPPrivateEndpoints.Test plan for issue:
e2e, e2e in prod
Is there any documentation that needs to be updated for this PR?
N/A
How do you know this will function as expected in production?
Cluster creation in prod