Fix Optional Parameter Bug for AddAzureAppConfiguration #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amerjusupovic
changed the title
amerjusupovic
changed the title
avanigupta
reviewed
Oct 11, 2022
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
avanigupta
reviewed
Oct 14, 2022
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
Outdated
Show resolved
Hide resolved
avanigupta
approved these changes
Oct 14, 2022
amerjusupovic
added a commit
that referenced
this pull request
Nov 28, 2022
* update keyvault secrets package version to 4.3.0, use TryCreate for validation (#351) * update keyvault package version, use trycreate for validation * use identifier instead of secreturi * naming and syntax fixes * Fix whitespace labelfilter bug (#352) * fix empty label bug * remove redundant null check * Remove select optimization (#358) * removed optimization * remove optimization * fix label filter change * fix preservedefaultquery test * Fix Optional Parameter Bug for AddAzureAppConfiguration (#359) * suppress adapter exceptions * remove unnecessary caught exceptions * remove using statement * Add LabelFilter null check for Feature Flags (#361) Fix #311 * Add .net7 as target framework, build with .net7 (#366) * change target frameworks, build version in script * fix comment to net7 * fix missing .net6 install * fix comment * test remove version for dotnet install * revert dotnet install version changes * update same projects target framework * upgrade to 5.2.0 (#368) Co-authored-by: Avani Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.