-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TeamCymruScout Solution #10939
base: master
Are you sure you want to change the base?
Conversation
self.state = StateManager( | ||
connection_string=consts.CONN_STRING, file_path=file_path | ||
) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a class instantiation Error
StateManager.__init__
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@v-prasadboke Here, the error reference is from NetskopeDataConnector and not from TeamCymruScout
'{}(method={}) : "{}" field is not set in the environment please set ' | ||
"the environment variable and run the app.".format( | ||
self.logs_starts_with, | ||
__method_name, | ||
label, | ||
) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
sensitive data (secret)
This expression logs
sensitive data (secret)
This expression logs
sensitive data (secret)
This expression logs
sensitive data (secret)
This expression logs
sensitive data (secret)
This expression logs
sensitive data (secret)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@v-prasadboke Here, one of the error indicates the issue in environment variable name AZURE_CLIENT_SECRET as seen in attached screenshot. As mentioned here we need to keep EnvironmentVariables same.
The other errors are from CofenceTriage, CofenseIntelligence and BitSight Data Connector.
""" | ||
__method_name = inspect.currentframe().f_code.co_name | ||
try: | ||
logs_data, flag = get_logs_data(self.query_constants.get(indicator_type)) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call Error
function get_logs_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@v-prasadboke Same for here as well. Error reference is from BitSightDataConnector and not from TeamCymruScout.
Hello @niralishah-crest, Please try to resolve KQL and Logo validation errors |
@v-prasadboke, we are trying to fix it from our end and will let you know as soon as possible. |
@v-prasadboke We have fixed Logo validation error but still we are unable to find the reason behind KQLValidation error. Can you please help us out on that? |
Hello @niralishah-crest, Can you please try to resolve branch Conflicts |
@v-prasadboke I have resolved the branch conflicts. |
@v-prasadboke Any updates on this PR review? |
@v-prasadboke Current CodeQL failures are from other integrations as I mentioned in above comments. Can you please look into it? |
@v-prasadboke |
Hello @niralishah-crest & @jayeshprajapaticrest, Can you please share working images of Function app. Also please update this branch from master once |
@v-prasadboke Please find the attached screenshot for running function app. |
@v-prasadboke |
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: