Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TeamCymruScout Solution #10939

Merged
merged 20 commits into from
Oct 9, 2024
Merged

Added TeamCymruScout Solution #10939

merged 20 commits into from
Oct 9, 2024

Conversation

niralishah-crest
Copy link
Contributor

Required items, please complete

Change(s):

  • Added Team Cymru Scout Solution

Reason for Change(s):

  • New Product

Version Updated:

  • Initial Version 3.0.0

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@niralishah-crest niralishah-crest requested review from a team as code owners August 7, 2024 14:12
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 7, 2024
View reviewed changes
Solutions/Team Cymru Scout/Data Connectors/TeamCymruScout/SharedCode/checkpoint_manager.py Fixed Show resolved Hide resolved
Solutions/Team Cymru Scout/Data Connectors/TeamCymruScout/SharedCode/utils.py Dismissed Show resolved Hide resolved
Solutions/Team Cymru Scout/Data Connectors/TeamCymruScout/SharedCode/utils.py
"""
__method_name = inspect.currentframe().f_code.co_name
try:
logs_data, flag = get_logs_data(self.query_constants.get(indicator_type))

Check failure

Code scanning / CodeQL

Wrong number of arguments in a call Error

Call to
function get_logs_data
Loading
with too many arguments; should be no more than 0.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-prasadboke Same for here as well. Error reference is from BitSightDataConnector and not from TeamCymruScout.
image

@v-prasadboke v-prasadboke self-assigned this Aug 8, 2024
@v-prasadboke v-prasadboke added the Solution Solution specialty review needed label Aug 8, 2024
@v-prasadboke
Copy link
Contributor

Hello @niralishah-crest, Please try to resolve KQL and Logo validation errors

@niralishah-crest
Copy link
Contributor Author

@v-prasadboke, we are trying to fix it from our end and will let you know as soon as possible.

@niralishah-crest
Copy link
Contributor Author

@v-prasadboke We have fixed Logo validation error but still we are unable to find the reason behind KQLValidation error. Can you please help us out on that?
Thanks.

@v-prasadboke v-prasadboke added the Connector Connector specialty review needed label Sep 4, 2024
@v-prasadboke
Copy link
Contributor

Hello @niralishah-crest, Can you please try to resolve branch Conflicts

@niralishah-crest
Copy link
Contributor Author

Hello @niralishah-crest, Can you please try to resolve branch Conflicts

@v-prasadboke I have resolved the branch conflicts.

@niralishah-crest
Copy link
Contributor Author

@v-prasadboke Any updates on this PR review?

@niralishah-crest
Copy link
Contributor Author

@v-prasadboke Current CodeQL failures are from other integrations as I mentioned in above comments. Can you please look into it?
Thanks.

@jayeshprajapaticrest
Copy link
Contributor

@v-prasadboke
Any update on the above PR?
Can you please proceed to review and get it merge as early as possible as this needs to be live as early as possible?
Its been around 1 and half month.

@v-prasadboke
Copy link
Contributor

Hello @niralishah-crest & @jayeshprajapaticrest, Can you please share working images of Function app. Also please update this branch from master once

@niralishah-crest
Copy link
Contributor Author

@v-prasadboke Please find the attached screenshot for running function app.
image
image

@jayeshprajapaticrest
Copy link
Contributor

@v-prasadboke
As mentioned above we have attached working screenshots of the Azure Function App(data connector). Can you please proceed with the review and get it merge ASAP?
Thanks in advanced.

@v-prasadboke
Copy link
Contributor

There are still some Code QL error failing

@niralishah-crest
Copy link
Contributor Author

There are still some Code QL error failing

@v-prasadboke I have made the changes in code. Can you plese re-run the CodeQl?

@v-prasadboke
Copy link
Contributor

Hello @niralishah-crest and @jayeshprajapaticrest there are still some Code-QL failure for secrets
Please use another keyword

@niralishah-crest
Copy link
Contributor Author

Hello @niralishah-crest and @jayeshprajapaticrest there are still some Code-QL failure for secrets Please use another keyword

@v-prasadboke As mentioned in above reply we need to use AZURE_CLIENT_SECRET only as Environment variable and retrieve its value in code.

@v-prasadboke v-prasadboke added Parser Parser specialty review needed New Solution For new Solutions which are new to Microsoft Sentinel labels Oct 9, 2024
@v-prasadboke v-prasadboke merged commit 84238cb into Azure:master Oct 9, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-prasadboke v-prasadboke v-prasadboke approved these changes

@v-atulyadav v-atulyadav v-atulyadav approved these changes

Assignees

@v-prasadboke v-prasadboke

Labels
Connector Connector specialty review needed New Solution For new Solutions which are new to Microsoft Sentinel Parser Parser specialty review needed Solution Solution specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niralishah-crest @v-prasadboke @jayeshprajapaticrest @v-atulyadav