Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data connectors and workbooks #10076

Closed

Conversation

nlepagnez
Copy link
Contributor

Change(s):

  • Updating Data Connector to correct errors on "LastReceived" values and IsConnected values
  • Updating the 2 workbooks to include new information and a comparison
  • Adding 2 new workbooks to analyze OfficeActivityLogs
  • Adding Parsers to support the new and updated workbooks.

Reason for Change(s):

  • Bug correction and enhancements

Version Updated:

  • Workbooks version updated
  • Dataconnector versions updated
  • Solution Version updated

@nlepagnez nlepagnez requested review from a team as code owners March 2, 2024 20:53
@nlepagnez
Copy link
Contributor Author

Hi,
I don't understand why my "Azure Deploy" JSON file is processed as a Workbook file and 3 tests crash because of that. I didn't find any file to add my deploy ARM Template to ignore.

Also, for the KQLValidation file, I have 2 errors that I don't understand :

  • An error on the SecurityEvents table that is not known. It's a standard table, why ?
  • An error on a column "TargetObject" that is created by an extend command and passed to a function T(*). It's a good query. Why the KQL Validation doesn't accept that ?

@v-atulyadav v-atulyadav added Connector Connector specialty review needed Workbook Workbook specialty review needed Solution Solution specialty review needed labels Mar 4, 2024
@v-prasadboke
Copy link
Contributor

Hello @nlepagnez, Thanks for raising this PR.
I see you have some concerns about KQL validation errors.

I'll investigate the errors and get back to you by 06 March, 2024

@v-prasadboke
Copy link
Contributor

Hello @nlepagnez, Try adding TargetObject to watchlist EchangeOnline.
And as for SecurityEvents I'll try updating this branch from master if that solves it, its good.
Else we can add this connector id to skipvalidation

Also please try resolve workbooks error

@nlepagnez
Copy link
Contributor Author

nlepagnez commented Mar 6, 2024

Hello @nlepagnez, Try adding TargetObject to watchlist EchangeOnline. And as for SecurityEvents I'll try updating this branch from master if that solves it, its good. Else we can add this connector id to skipvalidation

Also please try resolve workbooks error

Hi @v-prasadboke, thank you for this update.

Concerning Workbook error, it's concerning the "azuredeploy_ESI_ExchangeOnlineCollector_Automation.json" file, the error is corrected.

@nlepagnez
Copy link
Contributor Author

nlepagnez commented Mar 6, 2024

Hello @nlepagnez, Try adding TargetObject to watchlist EchangeOnline. And as for SecurityEvents I'll try updating this branch from master if that solves it, its good. Else we can add this connector id to skipvalidation

Also please try resolve workbooks error

Also , for the TargetObject Attribute, I'm not sure to understand what you ask to do. Do you want I add a column "targetObject" in the watchlist "ExchOnlineVIP" ? If it's that, this will add a column not understandable on a customer point of view and I have a doubt on how this will resolve the problem as the "TargetObject" attribute is on the Left part of the join but the watchlist is on the right part of the join.

@v-prasadboke
Copy link
Contributor

Hello @nlepagnez, Try adding TargetObject to watchlist EchangeOnline. And as for SecurityEvents I'll try updating this branch from master if that solves it, its good. Else we can add this connector id to skipvalidation
Also please try resolve workbooks error

Also , for the TargetObject Attribute, I'm not sure to understand what you ask to do. Do you want I add a column "targetObject" in the watchlist "ExchOnlineVIP" ? If it's that, this will add a column not understandable on a customer point of view and I have a doubt on how this will resolve the problem as the "TargetObject" attribute is on the Left part of the join but the watchlist is on the right part of the join.

Looking in it

@v-prasadboke
Copy link
Contributor

Hello @nlepagnez, Try adding TargetObject to watchlist EchangeOnline. And as for SecurityEvents I'll try updating this branch from master if that solves it, its good. Else we can add this connector id to skipvalidation
Also please try resolve workbooks error

Also , for the TargetObject Attribute, I'm not sure to understand what you ask to do. Do you want I add a column "targetObject" in the watchlist "ExchOnlineVIP" ? If it's that, this will add a column not understandable on a customer point of view and I have a doubt on how this will resolve the problem as the "TargetObject" attribute is on the Left part of the join but the watchlist is on the right part of the join.

Pardon me if I'm wrong, Nicolas but I believe the watchlist is on the left side.
let SearchUserDisplayName = T | join Watchlist on $left.TargetObject == $right.DisplayName | project TargetObject,SearchKey;

@nlepagnez
Copy link
Contributor Author

Pardon me if I'm wrong, Nicolas but I believe the watchlist is on the left side.
let SearchUserDisplayName = T | join Watchlist on $left.TargetObject == $right.DisplayName | project TargetObject,SearchKey;

Hi @v-prasadboke, sorry to insist but if I decompose the query :

So, TargetObject is used in T table that is the parameter of the function.
If I add TargetObject in the Watchlist :

  • This doesn't resolve the problem
  • This completly brake the user experience as he will see a TargetObject column to fill in the watchlist that is linked to nothing

Am I wrong on my analysis ?

@v-prasadboke
Copy link
Contributor

Hello @nlepagnez,
Got it. Understood the query.
We can move it to skipvalidation.
Until then can you please try to resolve branch conflicts.

Thanks.

@nlepagnez
Copy link
Contributor Author

Hello @nlepagnez, Got it. Understood the query. We can move it to skipvalidation. Until then can you please try to resolve branch conflicts.

Thanks.

Hi @v-prasadboke , I'm not able to solve conflicts as it requires write access that I don't have. How can I do that ?

@v-prasadboke
Copy link
Contributor

Hello @nlepagnez,
2 days ago I was facing the same issue while trying to push some commits. I had write access to the authors branch as I was in the contributor's list.
Maybe try after sometime.

@nlepagnez
Copy link
Contributor Author

Hello @nlepagnez, 2 days ago I was facing the same issue while trying to push some commits. I had write access to the authors branch as I was in the contributor's list. Maybe try after sometime.

Hi @v-prasadboke, I confirm that today also, afetr few days, I'm not able to resolve the conflict, no permission to do that.

@v-prasadboke
Copy link
Contributor

Maybe you can close this PR and raise a new one. I could have resolve the branch conflicts but you have made changes to data connector and it has conflicts.
Resolving that conflicts from my end can lead to unrequired things.

@nlepagnez
Copy link
Contributor Author

I do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed Solution Solution specialty review needed Workbook Workbook specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants