Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.3 Atlassian Beacon solution name update #10080

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

dark-binary
Copy link
Contributor

Required items, please complete

Change(s):

  • Solution Name updated to "Integration for Atlassian Beacon"
  • Updated version to 3.0.3 in main template
  • Updated Release Notes

Reason for Change(s):

  • To comply with Atlassian's legal naming convention

Version Updated:

  • N/A

Testing Completed:

  • N/A

Checked that the validations are passing and have addressed any issues that are present:

  • N/A

@dark-binary dark-binary requested review from a team as code owners March 3, 2024 23:39
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Mar 4, 2024
@v-rusraut
Copy link
Contributor

Hi @dark-binary,
Thanks for raising this PR. This PR will be investigated and we will update you about the same before 07 March, 2024

@v-rusraut
Copy link
Contributor

Hi @dark-binary,
If you want to update solution name, then you need to update solution name in data file.
After that you need to repackage it.
Thanks

@dark-binary
Copy link
Contributor Author

Hey @v-rusraut,

We tried updating the solution name in data file, but that packaging kept failing - since the folder name doesn't match with the solution's new name. Does this mean - we have to rename the folder from "Atlassian Beacon" to "Integration for Atlassian Beacon" as well?

Happy to jump on a call if that will make it easier :)

@v-rusraut
Copy link
Contributor

Hi @dark-binary,
Please rename folder from "Atlassian Beacon" to "Integration for Atlassian Beacon" and create package of solution.
Thanks

@v-atulyadav
Copy link
Contributor

Hi @dark-binary, please act on above comments. Thanks

@dark-binary
Copy link
Contributor Author

dark-binary commented Mar 12, 2024

Apologies for the delay - will rename the folder and update shortly

@dark-binary
Copy link
Contributor Author

Hey @v-rusraut and @v-atulyadav - completed 🙂

@v-atulyadav
Copy link
Contributor

Thanks @dark-binary, we will review this PR and let you know if anything required from your end. Thanks

@v-atulyadav v-atulyadav merged commit 6cfda15 into Azure:master Mar 18, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants