Re: DomainTools Microsoft Sentinel Solutions - CodeQL alerts - CRM:01390016354

[wesleya]

Change(s):

• Use hashlib.sha256 to avoid any ambiguity

Reason for Change(s):

• Attempting to resolve CodeQL alerts - CRM:01390016354

Version Updated:

• No

Testing Completed:

• Yes

Checked that the validations are passing and have addressed any issues that are present:

• Need Help

Additional Details:
We received CodeQL alerts asking us to switch hashing algorithms to sha256. For example:

11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/DomainRiskScore/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity

However, I'm unable to find any reference to md5 hash algorithm in the file referenced in the above example, or any of the files referenced in the full CodeQL alert. The only hash algorithm I see in the above referenced file is already sha256. I'm unfamiliar with how these alerts are generated, is it possible this alert was generated on an old package?

This PR changes import/syntax of sha256 to hashlib.sha256 in case that's what the "Use hashlib.sha256 to avoid any ambiguity" part of the CodeQL alert is referring to? Please review the changes in this PR. If this resolves the issue, I will apply the same update to the remaining files mentioned in the CodeQL alert and re-submit the PR. If no changes are needed, I'll close this PR. Please let me know if a different fix is required, thank you!

Full Code QL alert:

Due Date | Issue | SolutionName | FilePath | Fix |   |   |  
-- | -- | -- | -- | -- | -- | -- | --
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ReverseIPHost-Domains/__init__.py | Change sha1 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ClassicReverseIP/__init__.py | Change sha1 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/EnrichDomain/__init__.py | Change sha1 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/PivotByRegistrantName/__init__.py | Change sha1 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/DomainProfile/__init__.py | Change sha1 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/DomainSearch/__init__.py | Change sha1 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ReverseIPWhois/__init__.py | Change sha1 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ReverseIP/__init__.py | Change sha1 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/PivotMXHost/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ReturnTaggedWithAll/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ReverseEmailDomain/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/Evidence/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/PivotBySSLHash/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/InvestigateDomain/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ReverseNameServer/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/PivotByRegistrantOrg/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ReturnDomainsFromSearchHash/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ReverseEmail/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/HostingHistory/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/WhoisHistory/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/PivotNameServerHost/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ReverseWhois/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/WhoisLookup/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ParsedWhois/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/ReturnTaggedWithAny/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/PivotByNameserverIPAddress/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/PivotByMXIP/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/DomainRiskScore/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity
11/10/2024 | Use of unrecognized hash algorithm | DomainTools | Solutions/DomainTools/Playbooks/CustomConnector/DomainTools_FunctionAppConnector/PivotSSLEmail/__init__.py | Change md5 to sha256. Use hashlib.sha256 to avoid any ambiguity

[wesleya]

Hi @v-prasadboke, any thoughts on my questions in the "additional details" section of this PR description? Are we on the right track with this sample change? Or was the codeQL alert possibly run on an older version of this app?

[v-prasadboke]

Hello @wesleya, Can you please provide me write permission to this branch need to committ updated zip of the connector

[wesleya]

Hi @v-prasadboke I've sent you an invite, please let me know if you didn't receive it. Thank you!

[wesleya]

Hi @v-prasadboke just checking in, did you have any guidance on my previous questions? Or do you need anymore context from us? Thank you!