Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added few more activities related to Two Factor authentication as UseManagement suggested by reviewer #9217

Merged

Conversation

jayeshprajapaticrest
Copy link
Contributor

Change(s):

  • Added new more activities related to Two Factor Authentications.

Reason for Change(s):

  • Revisited few activities as per the suggested changes by reviewer to consider as User Management event instead of Audit event.

Version Updated:

  • Yes. Updated to 0.1.1

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@v-atulyadav
Copy link
Contributor

Hi @jayeshprajapaticrest, please check comments above from @vakohl and act accordingly. Thanks

@v-atulyadav
Copy link
Contributor

Hi @jayeshprajapaticrest, please act on @vakohl's comments. Thanks

@v-atulyadav
Copy link
Contributor

Hi @jayeshprajapaticrest, please update on above comments. Thanks

@v-rusraut
Copy link
Contributor

Hi @jayeshprajapaticrest,
Please work on above comment.

@v-atulyadav
Copy link
Contributor

Hi @jayeshprajapaticrest,
We're waiting for an update on this. Thanks

@v-atulyadav
Copy link
Contributor

Hi @niralishah-crest,
Have you completed all the changes? I can see a few open conversations. Thanks

@jayeshprajapaticrest
Copy link
Contributor Author

@v-atulyadav
We have started working on this PR suggested changes. Will update this by next week.
Thanks

@v-atulyadav
Copy link
Contributor

Noted @jayeshprajapaticrest. Thanks

@niralishah-crest
Copy link
Contributor

@v-atulyadav We have addressed PR comments.
Thanks

@v-atulyadav
Copy link
Contributor

Thanks @niralishah-crest.

@v-atulyadav v-atulyadav merged commit 70ca645 into Azure:master Mar 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants