Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated by Account=tolower(Account) #9692

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

v-muuppugund
Copy link
Contributor

@v-muuppugund v-muuppugund commented Dec 29, 2023

Required items, please complete

Change(s):

  • "By Account" changed to "By Account=tolower(Account)"

Reason for Change(s):

Version Updated:
-1.2.6

  • See guidance below

Testing Completed:

  • Yes

image

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


Copy link
Contributor

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

@v-muuppugund v-muuppugund marked this pull request as ready for review January 4, 2024 08:42
@v-muuppugund v-muuppugund requested review from a team as code owners January 4, 2024 08:42
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

Copy link

@contentautomationbot contentautomationbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KQL Best Practices Suggestions for: RDP_MultipleConnectionsFromSingleSystem.yaml

  1. Don't use '*' for searching text. Look in a specific column.
  2. Consider using the materialize() function for the 'endtime' variable if its assignment involves computation or calculation. This can improve performance.
  3. Consider using the materialize() function for the 'starttime' variable if its assignment involves computation or calculation. This can improve performance.
  4. Consider using Col =~ "lowercasestring" instead of tolower(Col) == "lowercasestring" for case-insensitive comparisons.
  5. Avoid filtering on calculated columns like 'LogonType'. Use in the format of 'T | where predicate(columnName == value)' instead of 'T | extend _value = Expression | where predicate(_value)'.
  6. Avoid filtering on calculated columns like 'LogonType'. Use in the format of 'T | where predicate(columnName == value)' instead of 'T | extend _value = Expression | where predicate(_value)'.
  7. Consider using hint.shufflekey=key with the summarize operator when group by keys have high cardinality.
  8. Consider using hint.strategy=broadcast when the left side is small and the right side is large.
  9. Consider using the lookup operator instead of join when the right side is small and the left side is large.
  10. Consider using hint.shufflekey= when both sides are too large.

Disclaimer: These suggestions are offered to enhance query efficiency and adherence to best practices. It is recommended to consider applying them for improved code quality, but their application is optional and context-dependent.

@v-atulyadav v-atulyadav added Detection Detection specialty review needed and removed draft labels Jan 8, 2024
Copy link
Contributor

@v-sudkharat v-sudkharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the changes, look's good.

@v-atulyadav v-atulyadav merged commit e1c92cb into master Jan 8, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Detection Detection specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid formatting for analytics rule "Multiple RDP connections from Single System"
3 participants