-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated by Account=tolower(Account) #9692
Conversation
Hello how are you I am GitHub bot |
Hello how are you I am GitHub bot |
Hello how are you I am GitHub bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KQL Best Practices Suggestions for: RDP_MultipleConnectionsFromSingleSystem.yaml
- Don't use '*' for searching text. Look in a specific column.
- Consider using the materialize() function for the 'endtime' variable if its assignment involves computation or calculation. This can improve performance.
- Consider using the materialize() function for the 'starttime' variable if its assignment involves computation or calculation. This can improve performance.
- Consider using Col =~ "lowercasestring" instead of tolower(Col) == "lowercasestring" for case-insensitive comparisons.
- Avoid filtering on calculated columns like 'LogonType'. Use in the format of 'T | where predicate(columnName == value)' instead of 'T | extend _value = Expression | where predicate(_value)'.
- Avoid filtering on calculated columns like 'LogonType'. Use in the format of 'T | where predicate(columnName == value)' instead of 'T | extend _value = Expression | where predicate(_value)'.
- Consider using hint.shufflekey=key with the summarize operator when group by keys have high cardinality.
- Consider using hint.strategy=broadcast when the left side is small and the right side is large.
- Consider using the lookup operator instead of join when the right side is small and the left side is large.
- Consider using hint.shufflekey= when both sides are too large.
Disclaimer: These suggestions are offered to enhance query efficiency and adherence to best practices. It is recommended to consider applying them for improved code quality, but their application is optional and context-dependent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified the changes, look's good.
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
-1.2.6
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Change(s):
Reason for Change(s):
Version updated:
Testing Completed:
Note: If updating a detection, you must update the version field.
Checked that the validations are passing and have addressed any issues that are present:
Note: Let us know if you have tried fixing the validation error and need help.