Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localization bug with Insider Build #2775

Merged
merged 1 commit into from
Aug 7, 2023
Merged

Conversation

skapur12
Copy link
Member

@skapur12 skapur12 commented Aug 7, 2023

In the current Insider Build, even when you switch the language, the translations still display in English. This is because after the OneLocBuild task is run, then npm run clean and npm run build-translations are run in succession in Build & Pack. (Essentially all language translations are built, then all cleaned out, then only English is built.)

This PR fixes this issue by getting rid of clean:resources (which isn’t really needed anyways since the translation files are overwritten/updated on every new build). Now the translations will stay and won’t immediately be cleaned out once built.

This PR also solves the error of the translation ID appearing when you switch the language to something non-English. Before, if a string in a non-English language didn’t have a translation, it would show the ID (e.g. application.buttons.editor). Now, it shows the English string instead (Editor).

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #2775 (601cb2d) into main (2d414dd) will not change coverage.
The diff coverage is n/a.

❗ Current head 601cb2d differs from pull request most recent head 90300b5. Consider uploading reports for the commit 90300b5 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2775   +/-   ##
=======================================
  Coverage   66.62%   66.62%           
=======================================
  Files        1209     1209           
  Lines       33750    33750           
  Branches     6219     6218    -1     
=======================================
  Hits        22485    22485           
  Misses      11126    11126           
  Partials      139      139           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d414dd...90300b5. Read the comment docs.

@skapur12 skapur12 merged commit f31b8b6 into main Aug 7, 2023
6 checks passed
@skapur12 skapur12 deleted the bugfix/translations branch August 7, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants