Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted Bonito fixes #2794

Merged
merged 8 commits into from
Sep 7, 2023
Merged

Assorted Bonito fixes #2794

merged 8 commits into from
Sep 7, 2023

Conversation

dpwatrous
Copy link
Member

@dpwatrous dpwatrous commented Sep 6, 2023

Ran into these issues while using bonito as an external dependency.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2794 (33547eb) into main (90fd62c) will decrease coverage by 0.01%.
The diff coverage is 61.22%.

❗ Current head 33547eb differs from pull request most recent head a41ef90. Consider uploading reports for the commit a41ef90 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2794      +/-   ##
==========================================
- Coverage   66.47%   66.47%   -0.01%     
==========================================
  Files        1226     1229       +3     
  Lines       33707    33744      +37     
  Branches     6102     6158      +56     
==========================================
+ Hits        22407    22431      +24     
- Misses      11166    11179      +13     
  Partials      134      134              
Files Changed Coverage Δ
.../components/form/default-form-control-resolver.tsx 56.25% <0.00%> (-3.75%) ⬇️
...bonito-ui/src/components/form/list-form-layout.tsx 63.01% <ø> (ø)
...s/bonito-ui/src/environment/browser-environment.ts 34.48% <0.00%> (ø)
...ackages/bonito-core/src/form/password-parameter.ts 30.76% <30.76%> (ø)
packages/bonito-core/src/form/boolean-parameter.ts 30.76% <50.00%> (+5.76%) ⬆️
packages/bonito-core/src/form/string-parameter.ts 84.61% <50.00%> (+1.28%) ⬆️
packages/bonito-ui/src/test-util/a11y.ts 66.66% <50.00%> (ø)
packages/bonito-core/src/form/index.ts 100.00% <100.00%> (ø)
packages/bonito-core/src/form/number-parameter.ts 100.00% <100.00%> (ø)
...ages/bonito-core/src/form/string-list-parameter.ts 86.66% <100.00%> (+0.95%) ⬆️
... and 4 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90fd62c...a41ef90. Read the comment docs.

@dpwatrous dpwatrous merged commit 131fe26 into main Sep 7, 2023
6 checks passed
@dpwatrous dpwatrous deleted the dpwatrous/bonito-updates branch September 7, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants