Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move typed emitter from dev dependencies to dependencies #2804

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

skapur12
Copy link
Member

Move 'typed emitter' in bonito-core package.json from dev-dependencies to dependencies to resolve an error

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2804 (071a6db) into main (017fcab) will not change coverage.
The diff coverage is n/a.

❗ Current head 071a6db differs from pull request most recent head d4769cf. Consider uploading reports for the commit d4769cf to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2804   +/-   ##
=======================================
  Coverage   66.48%   66.48%           
=======================================
  Files        1230     1230           
  Lines       33816    33816           
  Branches     6113     6114    +1     
=======================================
  Hits        22483    22483           
  Misses      11199    11199           
  Partials      134      134           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017fcab...d4769cf. Read the comment docs.

@skapur12 skapur12 changed the title Move typed emitter from dev dependenciess to dependencies Move typed emitter from dev dependencies to dependencies Sep 20, 2023
@skapur12 skapur12 merged commit 13bc75a into main Sep 20, 2023
6 checks passed
@skapur12 skapur12 deleted the bugfix/typed-emitter branch September 20, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants