Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable node communication mode editing #2810

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

dpwatrous
Copy link
Member

@dpwatrous dpwatrous commented Oct 16, 2023

This was only enabled in dev mode before. Now that we've updated to the latest API version, we can enable it in production.

@dpwatrous
Copy link
Member Author

Screenshots of the pool configuration view now that it can display real data:

Minimized with different current/target values:
Screenshot 2023-10-16 at 11 35 12 AM

Minimized with same or default values:
Screenshot 2023-10-16 at 11 35 22 AM

Expanded:
Screenshot 2023-10-16 at 11 35 31 AM

@dpwatrous dpwatrous force-pushed the dpwatrous/enable-node-comms-form branch from b91258c to d6b7e05 Compare October 16, 2023 15:55
@dpwatrous dpwatrous enabled auto-merge (squash) October 16, 2023 15:55
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #2810 (739fb33) into main (cbd42c1) will decrease coverage by 0.01%.
The diff coverage is 65.00%.

❗ Current head 739fb33 differs from pull request most recent head 75c8c8f. Consider uploading reports for the commit 75c8c8f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2810      +/-   ##
==========================================
- Coverage   66.54%   66.54%   -0.01%     
==========================================
  Files        1240     1240              
  Lines       33942    33961      +19     
  Branches     6192     6149      -43     
==========================================
+ Hits        22588    22600      +12     
- Misses      11219    11226       +7     
  Partials      135      135              
Files Coverage Δ
...ails/configuration/pool-configuration.component.ts 58.82% <87.50%> (+4.27%) ⬆️
desktop/src/app/decorators/pool-decorator.ts 76.47% <50.00%> (-8.15%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbd42c1...75c8c8f. Read the comment docs.

This was only enabled in dev mode before. Now that we've updated to the latest API version, we can enable in production.
@dpwatrous dpwatrous force-pushed the dpwatrous/enable-node-comms-form branch from d6b7e05 to 75c8c8f Compare October 16, 2023 20:23
@dpwatrous dpwatrous enabled auto-merge (squash) October 16, 2023 20:24
@dpwatrous dpwatrous merged commit edd7a35 into main Oct 16, 2023
6 checks passed
@dpwatrous dpwatrous deleted the dpwatrous/enable-node-comms-form branch October 16, 2023 20:47
gingi pushed a commit that referenced this pull request Nov 9, 2023
This was only enabled in dev mode before. Now that we've updated to the latest API version, we can enable it in production.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants