-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix contrast accessibility bugs #2830
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReneOv-MSFT
requested review from
cRui861,
dpwatrous,
gingi,
zfengms,
wiboris,
skapur12,
NickKouds and
wanghoppe
as code owners
November 7, 2023 21:36
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2830 +/- ##
=======================================
Coverage 67.29% 67.29%
=======================================
Files 1228 1228
Lines 33604 33604
Branches 6205 6205
=======================================
Hits 22615 22615
Misses 10842 10842
Partials 147 147
Continue to review full report in Codecov by Sentry.
|
cRui861
reviewed
Nov 8, 2023
cRui861
reviewed
Nov 8, 2023
cRui861
reviewed
Nov 21, 2023
desktop/src/app/components/pool/details/configuration/pool-configuration.scss
Outdated
Show resolved
Hide resolved
cRui861
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with contrasting colors:
https://azurebatch.visualstudio.com/BatchExplorer/_workitems/edit/1124
https://azurebatch.visualstudio.com/BatchExplorer/_workitems/edit/1125
https://azurebatch.visualstudio.com/BatchExplorer/_workitems/edit/1135
https://azurebatch.visualstudio.com/BatchExplorer/_workitems/edit/1128