Skip to content

Commit

Permalink
Updated API versions and readme (#3247)
Browse files Browse the repository at this point in the history
  • Loading branch information
krbar committed May 12, 2023
1 parent 45ace74 commit 5b26288
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ var builtInRoleNames = {
'Windows Admin Center Administrator Login': subscriptionResourceId('Microsoft.Authorization/roleDefinitions', 'a6333a3e-0164-44c3-b281-7a577aff287f')
}

resource privateLinkService 'Microsoft.Network/privateLinkServices@2022-01-01' existing = {
resource privateLinkService 'Microsoft.Network/privateLinkServices@2022-11-01' existing = {
name: last(split(resourceId, '/'))!
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ param managedIdentityName string

var addressPrefix = '10.0.0.0/16'

resource virtualNetwork 'Microsoft.Network/virtualNetworks@2022-01-01' = {
resource virtualNetwork 'Microsoft.Network/virtualNetworks@2022-11-01' = {
name: virtualNetworkName
location: location
properties: {
Expand All @@ -33,7 +33,7 @@ resource virtualNetwork 'Microsoft.Network/virtualNetworks@2022-01-01' = {
}
}

resource loadBalancer 'Microsoft.Network/loadBalancers@2022-01-01' = {
resource loadBalancer 'Microsoft.Network/loadBalancers@2022-11-01' = {
name: loadBalancerName
location: location
sku: {
Expand All @@ -53,7 +53,7 @@ resource loadBalancer 'Microsoft.Network/loadBalancers@2022-01-01' = {
}
}

resource managedIdentity 'Microsoft.ManagedIdentity/userAssignedIdentities@2018-11-30' = {
resource managedIdentity 'Microsoft.ManagedIdentity/userAssignedIdentities@2023-01-31' = {
name: managedIdentityName
location: location
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ param enableDefaultTelemetry bool = true

// General resources
// =================
resource resourceGroup 'Microsoft.Resources/resourceGroups@2021-04-01' = {
resource resourceGroup 'Microsoft.Resources/resourceGroups@2022-09-01' = {
name: resourceGroupName
location: location
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ param loadBalancerName string

var addressPrefix = '10.0.0.0/16'

resource virtualNetwork 'Microsoft.Network/virtualNetworks@2022-01-01' = {
resource virtualNetwork 'Microsoft.Network/virtualNetworks@2022-11-01' = {
name: virtualNetworkName
location: location
properties: {
Expand All @@ -30,7 +30,7 @@ resource virtualNetwork 'Microsoft.Network/virtualNetworks@2022-01-01' = {
}
}

resource loadBalancer 'Microsoft.Network/loadBalancers@2022-01-01' = {
resource loadBalancer 'Microsoft.Network/loadBalancers@2022-11-01' = {
name: loadBalancerName
location: location
sku: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ param enableDefaultTelemetry bool = true

// General resources
// =================
resource resourceGroup 'Microsoft.Resources/resourceGroups@2021-04-01' = {
resource resourceGroup 'Microsoft.Resources/resourceGroups@2022-09-01' = {
name: resourceGroupName
location: location
}
Expand Down
2 changes: 1 addition & 1 deletion modules/Network/privateLinkServices/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ This module deploys Network Private Link Services.
| :-- | :-- |
| `Microsoft.Authorization/locks` | [2020-05-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Authorization/2020-05-01/locks) |
| `Microsoft.Authorization/roleAssignments` | [2022-04-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Authorization/2022-04-01/roleAssignments) |
| `Microsoft.Network/privateLinkServices` | [2022-01-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Network/2022-01-01/privateLinkServices) |
| `Microsoft.Network/privateLinkServices` | [2022-11-01](https://learn.microsoft.com/en-us/azure/templates/Microsoft.Network/privateLinkServices) |

## Parameters

Expand Down
4 changes: 2 additions & 2 deletions modules/Network/privateLinkServices/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ param enableDefaultTelemetry bool = true
@description('Optional. Array of role assignment objects that contain the \'roleDefinitionIdOrName\' and \'principalId\' to define RBAC role assignments on this resource. In the roleDefinitionIdOrName attribute, you can provide either the display name of the role definition, or its fully qualified ID in the following format: \'/providers/Microsoft.Authorization/roleDefinitions/c2f4ef07-c644-48eb-af81-4b1b4947fb11\'.')
param roleAssignments array = []

resource defaultTelemetry 'Microsoft.Resources/deployments@2021-04-01' = if (enableDefaultTelemetry) {
resource defaultTelemetry 'Microsoft.Resources/deployments@2022-09-01' = if (enableDefaultTelemetry) {
name: 'pid-47ed15a6-730a-4827-bcb4-0fd963ffbd82-${uniqueString(deployment().name, location)}'
properties: {
mode: 'Incremental'
Expand All @@ -54,7 +54,7 @@ resource defaultTelemetry 'Microsoft.Resources/deployments@2021-04-01' = if (ena
}
}

resource privateLinkService 'Microsoft.Network/privateLinkServices@2022-01-01' = {
resource privateLinkService 'Microsoft.Network/privateLinkServices@2022-11-01' = {
name: name
location: location
tags: tags
Expand Down

0 comments on commit 5b26288

Please sign in to comment.