Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding private dns zones children #1044

Merged
merged 54 commits into from
Mar 4, 2022
Merged

Adding private dns zones children #1044

merged 54 commits into from
Mar 4, 2022

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Feb 25, 2022

Change

Adding DNS entries

Network: PrivateDnsZones

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

rahalan and others added 20 commits February 23, 2022 16:47
@rahalan rahalan enabled auto-merge (squash) February 25, 2022 08:54
eriqua
eriqua reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we follow the azure resource reference convention and go with capital letters for privateDnsZones children? e.g. A, AAAA, CNAME, ...

@rahalan
Copy link
Contributor Author

rahalan commented Feb 28, 2022

Should we follow the azure resource reference convention and go with capital letters for privateDnsZones children? e.g. A, AAAA, CNAME, ...

I had that before, but that also means we need to have capital directory names, which is different than would we do with all other modules. So I changed it to small letters. But I can change it back, if the team wants to go for capital letters, no problem

rahalan and others added 17 commits March 1, 2022 12:53
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/mx/readme.md
fb08992 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/ptr/readme.md
2ad4b44 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/soa/deploy.bicep
9cc7478 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/srv/readme.md
82cf9b4 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/srv/readme.md
1893c2b 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/txt/deploy.bicep
6aff505 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/txt/readme.md
4a14f45 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/txt/readme.md
0edb01e 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/txt/readme.md
8cd2a9b 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/aaaa/readme.md
94050f9 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/ptr/deploy.bicep
5daa92d 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/soa/readme.md
fe4c195 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan @AlexanderSehr
Update arm/Microsoft.Network/privateDnsZones/srv/readme.md
d6b8a77 
Co-authored-by: Alexander Sehr <[email protected]>
@rahalan
rename dir
c9cd8e8
@rahalan
rename dir
58cc07b
@rahalan
change to capital letters
fd51bcc
@rahalan
add new parameter file
afc5414
@github-actions
Copy link

github-actions bot commented Mar 2, 2022 •
edited
Loading

Unit Test Results

    1 files  1 suites   1m 49s ⏱️
    9 tests 9 ✔️     0 💤 0 ❌
320 runs  9 ✔️ 311 💤 0 ❌

Results for commit fa2799f.

♻️ This comment has been updated with latest results.

@rahalan rahalan merged commit 59d2602 into main Mar 4, 2022
@rahalan rahalan deleted the users/rahalan/addPrivateDnsZonesChildren branch March 4, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua left review comments

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@rahalan rahalan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahalan @AlexanderSehr @eriqua