Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding event grid system topics #1045

Merged
merged 16 commits into from
Mar 2, 2022
Merged

Adding event grid system topics #1045

merged 16 commits into from
Mar 2, 2022

Conversation

rahalan
Copy link
Contributor

@rahalan rahalan commented Feb 25, 2022

Change

Adding event grid system topics

EventGrid: System Topics

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@rahalan rahalan marked this pull request as draft February 25, 2022 12:39
@github-actions
Copy link

github-actions bot commented Feb 25, 2022

Unit Test Results

  1 files  ±0  1 suites  ±0   19s ⏱️ -6s
  6 tests +4  6 ✔️ +4    0 💤 ±0  0 ±0 
38 runs  +4  6 ✔️ +4  32 💤 ±0  0 ±0 

Results for commit 026f3d9. ± Comparison against base commit 854cae1.

This pull request removes 2 and adds 6 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/connections] used resource type [connections] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/connections] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/systemTopics] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/systemTopics] used resource type [locks] should use on of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/systemTopics] used resource type [privateEndpoints/privateDnsZoneGroups] should use on of the recent API version(s). Currently using [2021-02-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/systemTopics] used resource type [privateEndpoints] should use on of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/systemTopics] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2021-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.EventGrid/systemTopics] used resource type [systemTopics] should use on of the recent API version(s). Currently using [2021-12-01]

♻️ This comment has been updated with latest results.

@rahalan rahalan marked this pull request as ready for review February 26, 2022 08:39
@rahalan rahalan enabled auto-merge (squash) February 26, 2022 08:39
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure DevOps pipeline seems to be missing

@rahalan
Copy link
Contributor Author

rahalan commented Mar 2, 2022

Azure DevOps pipeline seems to be missing

done

@rahalan rahalan merged commit 5fe574f into main Mar 2, 2022
@rahalan rahalan deleted the users/rahalan/AddSystemTopics branch March 2, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants