Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Account: Parameterized support for HTTPs #1052

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

MariusStorhaug
Copy link
Contributor

Change

Added supportsHttpsTrafficOnly as an optional parameter, was hardcoded. This should be optional as when you are using NFS file shares, it cannot be enabled.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link

github-actions bot commented Feb 28, 2022

Unit Test Results

    1 files    1 suites   2m 10s ⏱️
  42 tests 42 ✔️     0 💤 0
386 runs  42 ✔️ 344 💤 0

Results for commit 615bd7d.

♻️ This comment has been updated with latest results.

@MariusStorhaug MariusStorhaug merged commit 1e662cf into main Feb 28, 2022
@MariusStorhaug MariusStorhaug deleted the users/mast/SA_NFSShare branch February 28, 2022 11:51
@MariusStorhaug MariusStorhaug restored the users/mast/SA_NFSShare branch March 1, 2022 21:31
@AlexanderSehr AlexanderSehr deleted the users/mast/SA_NFSShare branch March 2, 2022 12:49
@MariusStorhaug MariusStorhaug self-assigned this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants