Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VNET: Removed subnet property from main deployment #1081

Merged
merged 2 commits into from
Mar 4, 2022
Merged

VNET: Removed subnet property from main deployment #1081

merged 2 commits into from
Mar 4, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Mar 4, 2022 •
edited
Loading

Change

  • Removed subnet property from main deployment (as its not required an can cause issues)

Pipeline reference
Network: VirtualNetworks

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr linked an issue Mar 4, 2022 that may be closed by this pull request
VNET: Check if subnet parameter on vnet resource is definitely necessary #1075
Closed
@AlexanderSehr AlexanderSehr added this to the v 0.5 milestone Mar 4, 2022
@AlexanderSehr AlexanderSehr added bug Something isn't working [cat] modules category: modules labels Mar 4, 2022
@AlexanderSehr AlexanderSehr self-assigned this Mar 4, 2022
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) March 4, 2022 21:27
@MariusStorhaug MariusStorhaug merged commit 6ca9455 into main Mar 4, 2022
@MariusStorhaug MariusStorhaug deleted the users/alsehr/vnet branch March 4, 2022 21:27
@ahmadabdalla ahmadabdalla mentioned this pull request Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusStorhaug MariusStorhaug MariusStorhaug approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VNET: Check if subnet parameter on vnet resource is definitely necessary
2 participants
@AlexanderSehr @MariusStorhaug