Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Add RBAC to Private DNS records #1344

Merged
merged 12 commits into from
May 3, 2022
Merged

[Modules] Add RBAC to Private DNS records #1344

merged 12 commits into from
May 3, 2022

Conversation

simonbMS
Copy link
Contributor

Description

Add RBAC to Private DNS records

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: PrivateDnsZones

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change (I asked Erika)
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels Apr 28, 2022
simonbMS and others added 7 commits April 29, 2022 11:01
@simonbMS @eriqua
Update arm/Microsoft.Network/privateDnsZones/.parameters/parameters.json
180a39b 
Co-authored-by: Erika Gressi <[email protected]>
@simonbMS @eriqua
Update arm/Microsoft.Network/privateDnsZones/.parameters/parameters.json
93ba143 
Co-authored-by: Erika Gressi <[email protected]>
@simonbMS @eriqua
Update arm/Microsoft.Network/privateDnsZones/.parameters/parameters.json
ec2bead 
Co-authored-by: Erika Gressi <[email protected]>
@simonbMS @eriqua
Update arm/Microsoft.Network/privateDnsZones/.parameters/parameters.json
8948908 
Co-authored-by: Erika Gressi <[email protected]>
@simonbMS @eriqua
Update arm/Microsoft.Network/privateDnsZones/.parameters/parameters.json
54da135 
Co-authored-by: Erika Gressi <[email protected]>
@simonbMS @eriqua
Update arm/Microsoft.Network/privateDnsZones/.parameters/parameters.json
10b8ddd 
Co-authored-by: Erika Gressi <[email protected]>
@simonbMS @eriqua
Update arm/Microsoft.Network/privateDnsZones/.parameters/parameters.json
952988c 
Co-authored-by: Erika Gressi <[email protected]>
@simonbMS simonbMS enabled auto-merge (squash) April 29, 2022 11:43
eriqua
eriqua previously approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

eriqua
eriqua approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@simonbMS simonbMS merged commit 7ac68f8 into main May 3, 2022
@simonbMS simonbMS deleted the users/simonb/pvtDNS_RBAC branch May 3, 2022 11:09
@AlexanderSehr AlexanderSehr changed the title Add RBAC to Private DNS records [Modules] Add RBAC to Private DNS records Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr left review comments

@eriqua eriqua eriqua approved these changes

Assignees

@simonbMS simonbMS

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonbMS @AlexanderSehr @eriqua