Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Added Application Gateway Ingress Controler (AGIC) addon to AKS #1345

Merged
merged 11 commits into from
May 3, 2022
Merged

[Modules] Added Application Gateway Ingress Controler (AGIC) addon to AKS #1345

merged 11 commits into from
May 3, 2022

Conversation

JPEasier
Copy link
Contributor

@JPEasier JPEasier commented Apr 29, 2022 •
edited
Loading

Description

ContainerService: ManagedClusters

Application Gateway Ingress Controler (AGIC) is a addon configuration for AKS managed Clusster.

  • update managedCluster property in bicep
  • add new parameter to bicep
  • update readme

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ghost
Copy link

ghost commented Apr 29, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@AlexanderSehr
Copy link
Contributor

Adding the pipeline reference
ContainerService: ManagedClusters

@AlexanderSehr
Copy link
Contributor

@JPEasier, note you have a couple conflicts that need resolving

@JPEasier
Copy link
Contributor Author

Correlates to #1275

@JPEasier JPEasier mentioned this pull request Apr 29, 2022
Closed
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules labels Apr 29, 2022
@JPEasier
Copy link
Contributor Author

Wating for Bug: #1347

@AlexanderSehr
Copy link
Contributor

Correlates to #1275

@JPEasier you can continue without. As nice as linter is - it has some strange rules. For the time being I suggest to apply linter rules per common sense.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) May 3, 2022 12:58
eriqua
eriqua approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 074fb57 into main May 3, 2022
@AlexanderSehr AlexanderSehr deleted the users/jpeasier/aks_agic_addon branch May 3, 2022 13:07
@AlexanderSehr AlexanderSehr changed the title Add aks agic addon to managedCluster (AKS) [Modules] Added Application Gateway Ingress Controler (AGIC) addon to managedCluster (AKS) Jun 17, 2022
@AlexanderSehr AlexanderSehr changed the title [Modules] Added Application Gateway Ingress Controler (AGIC) addon to managedCluster (AKS) [Modules] Added Application Gateway Ingress Controler (AGIC) addon to AKS Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

@AlexanderSehr AlexanderSehr Awaiting requested review from AlexanderSehr

Assignees

@JPEasier JPEasier

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JPEasier @AlexanderSehr @eriqua