Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Switched from resource name to resource ID in RBAC deployment #1352

Merged
merged 1 commit into from
May 2, 2022
Merged

[Modules] Switched from resource name to resource ID in RBAC deployment #1352

merged 1 commit into from
May 2, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Apr 30, 2022 •
edited
Loading

Description

  • Swichted 'resource name' reference in RBAC deployment name to resource ID

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AnalysisServices: Servers

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Apr 30, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Apr 30, 2022
@AlexanderSehr AlexanderSehr linked an issue Apr 30, 2022 that may be closed by this pull request
[Feature Request]: Update RBAC deployment name to include the resourceID instead of resourceName to ensure we avoid colissions #1351
Closed
@github-actions
Copy link

github-actions bot commented Apr 30, 2022 •
edited
Loading

Unit Test Results

  1 files  1 suites   11s ⏱️
  4 tests 4 ✔️   0 💤 0 ❌
37 runs  4 ✔️ 33 💤 0 ❌

Results for commit 7375191.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) April 30, 2022 16:17
@AlexanderSehr AlexanderSehr mentioned this pull request Apr 30, 2022
Closed
4 tasks
@AlexanderSehr AlexanderSehr merged commit d967041 into main May 2, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1351_rbacID branch May 2, 2022 07:12
@AlexanderSehr AlexanderSehr changed the title [RBAC]: Switched from resource name to resource ID [Modules] Switched from resource name to resource ID Jun 17, 2022
@AlexanderSehr AlexanderSehr changed the title [Modules] Switched from resource name to resource ID [Modules] Switched from resource name to resource ID in RBAC deployment Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahalan rahalan rahalan approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@AlexanderSehr @rahalan