Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes] Set-ModuleReadMe when called w/ relative path #1366

Merged

Conversation

MrRoundRobin
Copy link
Member

Description

When Set-ModuleReadMe was called inside the same directory as the bicep file, there was an error and the readme could not be created.

This PR will fix this by resolving relative paths to full paths.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels May 6, 2022
@AlexanderSehr AlexanderSehr merged commit 79d0b0e into Azure:main May 6, 2022
@MrRoundRobin MrRoundRobin deleted the users/romuell/fix_module-readme branch May 6, 2022 16:45
@AlexanderSehr AlexanderSehr changed the title Fix Set-ModuleReadMe when called w/ relative path [Fixes] Set-ModuleReadMe when called w/ relative path Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants