Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] MongoDB: Removed throughput if database is deployed serverless #1571

Merged
merged 2 commits into from
Jun 25, 2022

Conversation

itpropro
Copy link
Contributor

Description

Replaced thoughput parameter with null, if the database capabilities contain EnableServerless.

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jun 22, 2022
@AlexanderSehr AlexanderSehr changed the title fix(mongodb): Removed throughput if database is deployed serverless [Modules] MongoDB: Removed throughput if database is deployed serverless Jun 22, 2022
@itpropro
Copy link
Contributor Author

Is there anything I need to contribute to close this PR @MrMCake ?

@AlexanderSehr
Copy link
Contributor

Is there anything I need to contribute to close this PR @MrMCake ?

A badge, like for the others ;) Preparing a merge branch now

@AlexanderSehr AlexanderSehr changed the base branch from main to users/itpropro/fixMongo June 25, 2022 17:11
@AlexanderSehr AlexanderSehr merged commit cbbffbb into Azure:users/itpropro/fixMongo Jun 25, 2022
AlexanderSehr added a commit that referenced this pull request Jun 27, 2022
…ess (#1571) (#1594)

* fix(mongodb):  Removed throughput if database is deployed serverless

* fix(mongodb):  Added thoughput ternary to collections

Co-authored-by: Jan-Henrik Damaschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants