Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wiki] Reset some of the feedback from Wiki walkthrough #1617

Merged
merged 2 commits into from
Jun 27, 2022
Merged

[Wiki] Reset some of the feedback from Wiki walkthrough #1617

merged 2 commits into from
Jun 27, 2022

Conversation

MariusStorhaug
Copy link
Contributor

Description

Resetting some of the adjustments from the wiki review which was undone in the #1599 PR.

Pipeline references

N/A

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug requested a review from a team as a code owner June 27, 2022 20:36
@MariusStorhaug MariusStorhaug changed the title Reset some of the feedback from Mate's wiki walkthrough Reset some of the feedback from Wiki walkthrough Jun 27, 2022
@AlexanderSehr AlexanderSehr added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 27, 2022
@AlexanderSehr AlexanderSehr changed the title Reset some of the feedback from Wiki walkthrough [Wiki] Reset some of the feedback from Wiki walkthrough Jun 27, 2022
@MariusStorhaug MariusStorhaug merged commit b8902d0 into main Jun 27, 2022
@MariusStorhaug MariusStorhaug deleted the users/mast/fixWiki branch June 27, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@MariusStorhaug MariusStorhaug

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MariusStorhaug @AlexanderSehr