-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more options to Microsoft.ContainerInstances/containergroups module #2175
Added more options to Microsoft.ContainerInstances/containergroups module #2175
Conversation
…users/fblix_jpeasier/1526-multiContainer
…/github.com/Azure/ResourceModules into users/fblix_jpeasier/1867-container-options
…users/fblix_jpeasier/1867-container-options
…/github.com/Azure/ResourceModules into users/fblix_jpeasier/1867-container-options
…/github.com/Azure/ResourceModules into users/fblix_jpeasier/1867-container-options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fblix and thanks a lot for this contribution. We're currently converting all modules to a new self-contained dependencies approach, for which we're going to deploy dependencies as part of module tests and also converting tests to use .bicep templates instead of .json parameters. For this module we already have a PR open #1874 which will cause merge conflicts to this PR once merged. For this reason I'm moving this PR to draft, I will prioritize the review of PR #1874 and let you know once merged.
modules/Microsoft.ContainerInstance/containerGroups/.test/private/dependencies.bicep
Outdated
Show resolved
Hide resolved
…ate/dependencies.bicep
modules/Microsoft.ContainerInstance/containerGroups/.test/private/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.ContainerInstance/containerGroups/deploy.bicep
Outdated
Show resolved
Hide resolved
…ate/deploy.test.bicep Co-authored-by: Alexander Sehr <[email protected]>
Description
#1867
Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist