Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] New Child Module Gallery Application #2465

Merged
merged 16 commits into from
Dec 19, 2022
Merged

[Modules] New Child Module Gallery Application #2465

merged 16 commits into from
Dec 19, 2022

Conversation

shawntmeyer
Copy link
Contributor

Description

This module is for application definitions in the Azure Compute Gallery.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@shawntmeyer shawntmeyer changed the title [New Module] Gallery Application - New [New Module] Gallery Application Dec 16, 2022
@shawntmeyer shawntmeyer marked this pull request as ready for review December 16, 2022 17:22
@shawntmeyer shawntmeyer requested a review from a team as a code owner December 16, 2022 17:22
@AlexanderSehr AlexanderSehr changed the title [New Module] Gallery Application [Modules] New Module Gallery Application Dec 16, 2022
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label Dec 16, 2022
@eriqua eriqua changed the title [Modules] New Module Gallery Application [Modules] New Child Module Gallery Application Dec 17, 2022
@shawntmeyer
Copy link
Contributor Author

Erika, id be happy to merge the tests into the .common folder but this isnt how the .images folder was configured. Also, the images module uses the endOfLife which is not from reference. Should this be changed for consistency?

@eriqua
Copy link
Contributor

eriqua commented Dec 19, 2022

Erika, id be happy to merge the tests into the .common folder but this isnt how the .images folder was configured. Also, the images module uses the endOfLife which is not from reference. Should this be changed for consistency?

@shawntmeyer you are right, the gallery test isn't configured as per test design. It should ideally have a common test where as many parameters and features are tested plus a min test where only the parent required parameters are tested. While we double check if there has been a good reason why it has been configured in that way (sometimes additional tests are required due to conflicting features) I'd suggest to skip the update of the image module and test for now, but only add the gallery applications deployment to the gallery common test. I'll open an issue for what you correctly pointed out so that we can fix it in a different PR.

@shawntmeyer
Copy link
Contributor Author

I added the applications test to the common test.

Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eriqua eriqua merged commit 1a02887 into Azure:main Dec 19, 2022
@shawntmeyer shawntmeyer deleted the Gallery-Application branch December 19, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants