Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI Environment] PSRule fix tags suppression group and add tags to purview #3086

Merged
merged 1 commit into from
Apr 6, 2023
Merged

[CI Environment] PSRule fix tags suppression group and add tags to purview #3086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .ps-rule/na-suppress.Rule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ spec:
- Microsoft.Authorization/policyExemptions
- Microsoft.Authorization/policySetDefinitions
- Microsoft.Authorization/locks
- Microsoft.AADDomainServices/oucontainer
- Microsoft.ApiManagementservice/eventGridFilters
- Microsoft.AAD/DomainServices/oucontainer
- Microsoft.ApiManagement/service/eventGridFilters
- Microsoft.EventGrid/eventSubscriptions
- Microsoft.Automation/automationAccounts/softwareUpdateConfigurations
20 changes: 20 additions & 0 deletions modules/Microsoft.Purview/accounts/.test/common/deploy.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ module testDeployment '../../deploy.bicep' = {
}
service: 'account'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
]
portalPrivateEndpoints: [
Expand All @@ -105,6 +109,10 @@ module testDeployment '../../deploy.bicep' = {
}
service: 'portal'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
]
storageBlobPrivateEndpoints: [
Expand All @@ -116,6 +124,10 @@ module testDeployment '../../deploy.bicep' = {
}
service: 'blob'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
]
storageQueuePrivateEndpoints: [
Expand All @@ -127,6 +139,10 @@ module testDeployment '../../deploy.bicep' = {
}
service: 'queue'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
]
eventHubPrivateEndpoints: [
Expand All @@ -138,6 +154,10 @@ module testDeployment '../../deploy.bicep' = {
}
service: 'namespace'
subnetResourceId: nestedDependencies.outputs.subnetResourceId
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
]
enableDefaultTelemetry: enableDefaultTelemetry
Expand Down
50 changes: 45 additions & 5 deletions modules/Microsoft.Purview/accounts/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,10 @@ module accounts './Microsoft.Purview/accounts/deploy.bicep' = {
}
service: 'account'
subnetResourceId: '<subnetResourceId>'
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
]
diagnosticEventHubAuthorizationRuleId: '<diagnosticEventHubAuthorizationRuleId>'
Expand All @@ -263,6 +267,10 @@ module accounts './Microsoft.Purview/accounts/deploy.bicep' = {
}
service: 'namespace'
subnetResourceId: '<subnetResourceId>'
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
]
location: '<location>'
Expand All @@ -277,6 +285,10 @@ module accounts './Microsoft.Purview/accounts/deploy.bicep' = {
}
service: 'portal'
subnetResourceId: '<subnetResourceId>'
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
]
publicNetworkAccess: 'Disabled'
Expand All @@ -298,6 +310,10 @@ module accounts './Microsoft.Purview/accounts/deploy.bicep' = {
}
service: 'blob'
subnetResourceId: '<subnetResourceId>'
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
]
storageQueuePrivateEndpoints: [
Expand All @@ -309,6 +325,10 @@ module accounts './Microsoft.Purview/accounts/deploy.bicep' = {
}
service: 'queue'
subnetResourceId: '<subnetResourceId>'
tags: {
Environment: 'Non-Prod'
Role: 'DeploymentValidation'
}
}
]
tags: {
Expand Down Expand Up @@ -348,7 +368,11 @@ module accounts './Microsoft.Purview/accounts/deploy.bicep' = {
]
},
"service": "account",
"subnetResourceId": "<subnetResourceId>"
"subnetResourceId": "<subnetResourceId>",
"tags": {
"Environment": "Non-Prod",
"Role": "DeploymentValidation"
}
}
]
},
Expand Down Expand Up @@ -389,7 +413,11 @@ module accounts './Microsoft.Purview/accounts/deploy.bicep' = {
]
},
"service": "namespace",
"subnetResourceId": "<subnetResourceId>"
"subnetResourceId": "<subnetResourceId>",
"tags": {
"Environment": "Non-Prod",
"Role": "DeploymentValidation"
}
}
]
},
Expand All @@ -411,7 +439,11 @@ module accounts './Microsoft.Purview/accounts/deploy.bicep' = {
]
},
"service": "portal",
"subnetResourceId": "<subnetResourceId>"
"subnetResourceId": "<subnetResourceId>",
"tags": {
"Environment": "Non-Prod",
"Role": "DeploymentValidation"
}
}
]
},
Expand All @@ -438,7 +470,11 @@ module accounts './Microsoft.Purview/accounts/deploy.bicep' = {
]
},
"service": "blob",
"subnetResourceId": "<subnetResourceId>"
"subnetResourceId": "<subnetResourceId>",
"tags": {
"Environment": "Non-Prod",
"Role": "DeploymentValidation"
}
}
]
},
Expand All @@ -451,7 +487,11 @@ module accounts './Microsoft.Purview/accounts/deploy.bicep' = {
]
},
"service": "queue",
"subnetResourceId": "<subnetResourceId>"
"subnetResourceId": "<subnetResourceId>",
"tags": {
"Environment": "Non-Prod",
"Role": "DeploymentValidation"
}
}
]
},
Expand Down