Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Cognitive Services accounts - CMK fix + API update #3259

Merged
merged 4 commits into from
May 21, 2023
Merged

[Modules] Cognitive Services accounts - CMK fix + API update #3259

merged 4 commits into from
May 21, 2023

Conversation

krbar
Copy link
Contributor

@krbar krbar commented May 16, 2023

Description

PR resolves #3097 by:

  • setting restrictOutboundNetworkAccess=false for the Customer Managed Keys test case. Otherwise the key cannot be accessed
  • update of the API versions

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
CognitiveServices - Accounts

Type of Change

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@krbar krbar linked an issue May 16, 2023 that may be closed by this pull request
[Failed pipeline] CognitiveServices - Accounts #3097
Closed
@krbar krbar self-assigned this May 16, 2023
@krbar krbar marked this pull request as ready for review May 17, 2023 10:02
@krbar krbar requested a review from a team as a code owner May 17, 2023 10:02
@krbar krbar enabled auto-merge (squash) May 17, 2023 10:02
@krbar krbar added the [cat] modules category: modules label May 17, 2023
@krbar krbar merged commit cfd6600 into main May 21, 2023
@krbar krbar deleted the users/krbar/3097-cognitiveservices-accounts branch May 21, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@krbar krbar

Labels
[cat] modules category: modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] CognitiveServices - Accounts
2 participants
@krbar @AlexanderSehr