Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Added support for Capacity Reservation for the Log Analytics Workspace Module #3345

Merged
merged 2 commits into from
Jun 17, 2023

Conversation

ahmadabdalla
Copy link
Contributor

Closes #3332

Description

Updated SKU Name to align with the public documentation.
Added support for capacity reservation SKU and options

NOTE: Although tested in isolation and it is successful. I am not adding test cases for these parameters just in case if it causes charges on Azure subscriptions

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
OperationalInsights - Workspaces

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added enhancement New feature or request [cat] modules category: modules labels Jun 16, 2023
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner June 16, 2023 10:25
@ahmadabdalla ahmadabdalla self-assigned this Jun 16, 2023
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@ahmadabdalla ahmadabdalla merged commit 2eec317 into main Jun 17, 2023
15 checks passed
@ahmadabdalla ahmadabdalla deleted the users/ahmad/3332_Law branch June 17, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: log analytics workspace sku parameter
2 participants