Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated NetApp Module to support User Assigned Identities #3347

Merged
merged 4 commits into from
Jun 24, 2023
Merged

[Modules] Updated NetApp Module to support User Assigned Identities #3347

merged 4 commits into from
Jun 24, 2023

Conversation

ahmadabdalla
Copy link
Contributor

Closes #2990

Description

Allowed support for User Assigned Identity. Enabling CMK for the Module is addressed in another Issue

Pipeline references

Pipeline
NetApp - NetAppAccounts

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added enhancement New feature or request [cat] modules category: modules labels Jun 18, 2023
@ahmadabdalla ahmadabdalla added this to the Release v0.11.0 milestone Jun 18, 2023
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner June 18, 2023 07:41
@ahmadabdalla ahmadabdalla self-assigned this Jun 18, 2023
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) June 18, 2023 07:41
eriqua
eriqua approved these changes Jun 24, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@ahmadabdalla ahmadabdalla merged commit 8ad6109 into main Jun 24, 2023
14 checks passed
@ahmadabdalla ahmadabdalla deleted the users/ahmad/nfsaccounts_tests branch June 24, 2023 10:06
@eriqua eriqua changed the title [Modules] Updated NFS Accounts Module to support User Assigned Identities [Modules] Updated NetApp Module to support User Assigned Identities Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@ahmadabdalla ahmadabdalla

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
Release v0.11.0
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Extend Azure NetApp Files module with identity
2 participants
@ahmadabdalla @eriqua