Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand Microsoft.ContainerService/managedClusters/agentPool properties object #806

Merged
merged 144 commits into from
Dec 15, 2021
Merged

Expand Microsoft.ContainerService/managedClusters/agentPool properties object #806

merged 144 commits into from
Dec 15, 2021

Conversation

lsnoddy
Copy link
Member

@lsnoddy lsnoddy commented Dec 13, 2021 •
edited
Loading

Change

Added all available properties as parameters for the agentPool module instead of relying on a single agentPoolProperties object.

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

lsnoddy and others added 30 commits November 15, 2021 17:30
@lsnoddy
Update to new child-resource structure progress
30d0ec1
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules int…
7b8ea9f 
…o main
@lsnoddy
Progress check-in
e725966
@lsnoddy
Added managed cluster name parameter
0454fa2
@lsnoddy
Updated readme
aad50a9
@lsnoddy
Merge branch 'Azure:main' into main
8e3f37e
@lsnoddy
Updated readme file
eb9ac8f
@lsnoddy
Updated readme
4895bfd
Push updated Readme file(s)
a24964d
@lsnoddy
Updated readme
9da3646
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
3ccc8dd
@lsnoddy
Added test param file
4210ecf
@lsnoddy
Updated subscriptionId
4ce1e3b
@lsnoddy
Added test param file
a9726f6
@lsnoddy
Removed subscription id
ed984d6
@lsnoddy
Modified test variables
0380167
@lsnoddy
Modified test variables
ecf407a
@lsnoddy
Test dependency values
40ffa48
@lsnoddy
Updated parameters
f03ac3a
@lsnoddy
Removed local files used for testing
d056b74
@lsnoddy
Merge branch 'Azure:main' into main
8f3447b
@lsnoddy
Updated readme
a792c19
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
d128feb
@lsnoddy
Updated readme
cc8c087
@lsnoddy
Revert "Push updated Readme file(s)"
30a00ca 
This reverts commit a24964d.
@lsnoddy
Updated readme
20a3955
@lsnoddy
Updated both readme files and agentPool paramter name consistency
5139c68
Push updated Readme file(s)
39ae6ce
@lsnoddy
Merge branch 'Azure:main' into main
20c6a88
@lsnoddy
Updated Api to API to appease linter
5621dcb
AlexanderSehr
AlexanderSehr reviewed Dec 13, 2021
View reviewed changes
arm/README.md Outdated Show resolved Hide resolved
@AlexanderSehr AlexanderSehr added [cat] modules category: modules enhancement New feature or request labels Dec 13, 2021
AlexanderSehr
AlexanderSehr reviewed Dec 15, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@lsnoddy lsnoddy merged commit 0ca3072 into Azure:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@lsnoddy lsnoddy

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand Microsoft.ContainerService/managedClusters/agentPool properties object
2 participants
@lsnoddy @AlexanderSehr