Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment code for Diagnostic Settings #811

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

senavar
Copy link
Contributor

@senavar senavar commented Dec 14, 2021

Change

Update code for Diagnostic Settings deployment for more simplified approach

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Pipelines were ran for the storage account, SQL DB, and Log Analytics modules from PR #765

Wiki has been updated already to reflect this change: https://github.com/Azure/ResourceModules/wiki/ModulesDesign#diagnostic-settings

@senavar senavar added the enhancement New feature or request label Dec 14, 2021
@senavar senavar linked an issue Dec 14, 2021 that may be closed by this pull request
@senavar senavar added the [cat] modules category: modules label Dec 14, 2021
rahalan
rahalan previously approved these changes Dec 14, 2021
@AlexanderSehr AlexanderSehr merged commit 19f4db4 into main Dec 14, 2021
@AlexanderSehr AlexanderSehr deleted the users/senavar/diagnosticSettingsUpdate branch December 14, 2021 20:49
@senavar senavar restored the users/senavar/diagnosticSettingsUpdate branch January 10, 2022 17:27
@senavar senavar deleted the users/senavar/diagnosticSettingsUpdate branch January 10, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check & test if we can simplify the diagnostic settings
3 participants