Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users/lsnoddy/remove preview feature #822

Merged
merged 147 commits into from
Dec 20, 2021
Merged

Users/lsnoddy/remove preview feature #822

merged 147 commits into from
Dec 20, 2021

Conversation

lsnoddy
Copy link
Member

@lsnoddy lsnoddy commented Dec 17, 2021

Change

Removed code associated with the CustomNodeConfigurationPreview for AKS node pools as it results in a deployment error in subscriptions where the CustomNodeConfigurationPreview is not registered.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

lsnoddy and others added 30 commits November 15, 2021 17:30
@lsnoddy
Update to new child-resource structure progress
30d0ec1
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules int…
7b8ea9f 
…o main
@lsnoddy
Progress check-in
e725966
@lsnoddy
Added managed cluster name parameter
0454fa2
@lsnoddy
Updated readme
aad50a9
@lsnoddy
Merge branch 'Azure:main' into main
8e3f37e
@lsnoddy
Updated readme file
eb9ac8f
@lsnoddy
Updated readme
4895bfd
Push updated Readme file(s)
a24964d
@lsnoddy
Updated readme
9da3646
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
3ccc8dd
@lsnoddy
Added test param file
4210ecf
@lsnoddy
Updated subscriptionId
4ce1e3b
@lsnoddy
Added test param file
a9726f6
@lsnoddy
Removed subscription id
ed984d6
@lsnoddy
Modified test variables
0380167
@lsnoddy
Modified test variables
ecf407a
@lsnoddy
Test dependency values
40ffa48
@lsnoddy
Updated parameters
f03ac3a
@lsnoddy
Removed local files used for testing
d056b74
@lsnoddy
Merge branch 'Azure:main' into main
8f3447b
@lsnoddy
Updated readme
a792c19
@lsnoddy
Merge branch 'main' of https://github.com/lsnoddy/ResourceModules
d128feb
@lsnoddy
Updated readme
cc8c087
@lsnoddy
Revert "Push updated Readme file(s)"
30a00ca 
This reverts commit a24964d.
@lsnoddy
Updated readme
20a3955
@lsnoddy
Updated both readme files and agentPool paramter name consistency
5139c68
Push updated Readme file(s)
39ae6ce
@lsnoddy
Merge branch 'Azure:main' into main
20c6a88
@lsnoddy
Updated Api to API to appease linter
5621dcb
lsnoddy and others added 23 commits December 13, 2021 08:54
@lsnoddy
Test revert
0f5f1ad
@lsnoddy
Restore file
6c5005c
@lsnoddy
Updated
40d4228
@lsnoddy
Removed agentPool example
757c7b9
@lsnoddy
Removed extra spaces and changed comparison to not equal
eb4fefb
@lsnoddy
Removed agen pool example
970c912
Push updated Readme file(s)
c636da2
@lsnoddy
Restored file
1596243
@lsnoddy
Added missing network firewall policies link
b7c8cc6
@lsnoddy
Revert "Push updated Readme file(s)"
e6f9847 
This reverts commit c636da2.
@lsnoddy
Moved managedCluster reference down to agent pool resource section
0d32209
Push updated Readme file(s)
c0aecda
@lsnoddy
Revert "Push updated Readme file(s)"
158971b 
This reverts commit c0aecda.
@lsnoddy
Merge branch 'main' into main
cf73a0c
Push updated Readme file(s)
86d2ba8
@lsnoddy
Revert "Push updated Readme file(s)"
39782ce 
This reverts commit 86d2ba8.
@lsnoddy @AlexanderSehr
Update arm/Microsoft.ContainerService/managedClusters/agentPools/depl…
f125926 
…oy.bicep

Co-authored-by: Alexander Sehr <[email protected]>
@lsnoddy @AlexanderSehr
Update arm/Microsoft.ContainerService/managedClusters/agentPools/depl…
1ba9267 
…oy.bicep

Co-authored-by: Alexander Sehr <[email protected]>
@lsnoddy @AlexanderSehr
Update arm/Microsoft.ContainerService/managedClusters/agentPools/depl…
0728bff 
…oy.bicep

Co-authored-by: Alexander Sehr <[email protected]>
@lsnoddy @AlexanderSehr
Update arm/Microsoft.ContainerService/managedClusters/agentPools/depl…
3bbb817 
…oy.bicep

Co-authored-by: Alexander Sehr <[email protected]>
@lsnoddy
Merge branch 'Azure:main' into main
79c111f
@lsnoddy
Merge branch 'Azure:main' into main
4ac2937
@lsnoddy
Removed code associated with CustomNodeConfigPreview
fdadc90
@lsnoddy lsnoddy added the [cat] modules category: modules label Dec 17, 2021
@lsnoddy lsnoddy added this to the v 0.4 milestone Dec 17, 2021
@lsnoddy lsnoddy self-assigned this Dec 17, 2021
@lsnoddy lsnoddy linked an issue Dec 17, 2021 that may be closed by this pull request
Remove Preview feature Microsoft.ContainerService/CustomNodeConfigPreview #820
Closed
@AlexanderSehr AlexanderSehr merged commit 67e13f2 into Azure:main Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@lsnoddy lsnoddy

Labels
[cat] modules category: modules
Projects
None yet
Milestone
v 0.4
Development

Successfully merging this pull request may close these issues.

Remove Preview feature Microsoft.ContainerService/CustomNodeConfigPreview
2 participants
@lsnoddy @AlexanderSehr