-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Synapse Private Link Hubs #856
Merged
AlexanderSehr
merged 29 commits into
Azure:users/repajta/852_synapse_privatelinkhubs_module
from
DataStoics:main
Jan 5, 2022
Merged
Added support for Synapse Private Link Hubs #856
AlexanderSehr
merged 29 commits into
Azure:users/repajta/852_synapse_privatelinkhubs_module
from
DataStoics:main
Jan 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for Synapse Private Link Hubs
Co-authored-by: Alexander Sehr <[email protected]>
AlexanderSehr
requested changes
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a pipeline in the .azuredevops folder
arm/Microsoft.Synapse/privateLinkHubs/.parameters/parameters.json
Outdated
Show resolved
Hide resolved
arm/Microsoft.Synapse/privateLinkHubs/.parameters/parameters.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
renepajta
commented
Jan 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes resolved.
renepajta
changed the base branch from
main
to
users/repajta/852_synapse_privatelinkhubs_module
January 5, 2022 13:31
AlexanderSehr
approved these changes
Jan 5, 2022
AlexanderSehr
merged commit Jan 5, 2022
5667fe5
into
Azure:users/repajta/852_synapse_privatelinkhubs_module
AlexanderSehr
added a commit
that referenced
this pull request
Jan 6, 2022
* Added support for Synapse Private Link Hubs (#856) * Added support for Synapse Private Link Hubs * Fixed typo in Github workflow * Create new workflow for deploying Synapse Private Link Hub * Added support for Locks, RBAC and Private Endpoints * Updated ReadMe file * Fixed outputs & updated ReadMe * Switched back to main branch Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/.bicep/nested_rbac.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/.bicep/nested_rbac.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/readme.md Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/readme.md Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/readme.md Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/readme.md Co-authored-by: Alexander Sehr <[email protected]> * Fixed naming, added ADO pipeline, updated README * Removed TODOs in ReadMe * Reversed changes in auto-generated Readme to avoid conflicts * Remove lock settings from parameter file * Updated based on comments * Updated readme.md Co-authored-by: Alexander Sehr <[email protected]> * Update arm/Microsoft.Synapse/privateLinkHubs/.parameters/parameters.json Co-authored-by: Alexander Sehr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Added support for Synapse Private Link Hubs.
The module is able to deploy Synapse Private Link Hubs including Locks, RBACs and Private Endpoints.
Type of Change
Checklist