Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Synapse Private Link Hubs #856

Conversation

renepajta
Copy link
Member

@renepajta renepajta commented Jan 4, 2022

Change

Added support for Synapse Private Link Hubs.

The module is able to deploy Synapse Private Link Hubs including Locks, RBACs and Private Endpoints.

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Co-authored-by: Alexander Sehr <[email protected]>
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a pipeline in the .azuredevops folder

renepajta and others added 16 commits January 4, 2022 15:47
Copy link
Member Author

@renepajta renepajta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes resolved.

arm/README.md Outdated Show resolved Hide resolved
@renepajta renepajta changed the base branch from main to users/repajta/852_synapse_privatelinkhubs_module January 5, 2022 13:31
@AlexanderSehr AlexanderSehr merged commit 5667fe5 into Azure:users/repajta/852_synapse_privatelinkhubs_module Jan 5, 2022
AlexanderSehr added a commit that referenced this pull request Jan 6, 2022
* Added support for Synapse Private Link Hubs (#856)

* Added support for Synapse Private Link Hubs

* Fixed typo in Github workflow

* Create new workflow for deploying Synapse Private Link Hub

* Added support for Locks, RBAC and Private Endpoints

* Updated ReadMe file

* Fixed outputs & updated ReadMe

* Switched back to main branch

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/.bicep/nested_rbac.bicep

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/.bicep/nested_rbac.bicep

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr <[email protected]>

* Fixed naming, added ADO pipeline, updated README

* Removed TODOs in ReadMe

* Reversed changes in auto-generated Readme to avoid conflicts

* Remove lock settings from parameter file

* Updated based on comments

* Updated readme.md

Co-authored-by: Alexander Sehr <[email protected]>

* Update arm/Microsoft.Synapse/privateLinkHubs/.parameters/parameters.json

Co-authored-by: Alexander Sehr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants