Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added improved error fetching for failed deployments #866

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Added improved error fetching for failed deployments #866

merged 2 commits into from
Jan 6, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jan 6, 2022 •
edited
Loading

Change

Added deployment error fetching based on deployment name if provisioning failed without an exception

Pipeline reference to show that it does not fail:
Storage: StorageAccounts

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

@AlexanderSehr AlexanderSehr self-assigned this Jan 6, 2022
@AlexanderSehr AlexanderSehr linked an issue Jan 6, 2022 that may be closed by this pull request
Bug: Failed deployments return as succeeded #857
Closed
@AlexanderSehr AlexanderSehr added this to the v 0.4 milestone Jan 6, 2022
@AlexanderSehr AlexanderSehr added [cat] pipelines category: pipelines bug Something isn't working labels Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022 •
edited
Loading

Unit Test Results

    1 files  ±    0    1 suites  ±0   2m 9s ⏱️ +29s
  42 tests +  22  42 ✔️ +22      0 💤 ±    0  0 ❌ ±0 
375 runs  +143  42 ✔️ +22  333 💤 +121  0 ❌ ±0 

Results for commit 1244836. ± Comparison against base commit f6205f5.

This pull request removes 20 and adds 42 tests. Note that renamed tests count towards both. 
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/jobSchedules] used resource type [automationAccounts/jobSchedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/modules] used resource type [automationAccounts/modules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/runbooks] used resource type [automationAccounts/runbooks] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/schedules] used resource type [automationAccounts/schedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/softwareUpdateConfigurations] used resource type [automationAccounts/softwareUpdateConfigurations] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts/variables] used resource type [automationAccounts/variables] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/jobSchedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/modules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/runbooks] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Automation/automationAccounts] used resource type [automationAccounts/schedules] should use on of the recent API version(s). Currently using [2020-01-13-preview]
…

/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers/immutabilityPolicies] used resource type [storageAccounts/blobServices/containers/immutabilityPolicies] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers] used resource type [storageAccounts/blobServices/containers/immutabilityPolicies] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices/containers] used resource type [storageAccounts/blobServices/containers] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [diagnosticsettings] should use on of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [storageAccounts/blobServices/containers/immutabilityPolicies] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [storageAccounts/blobServices/containers] should use on of the recent API version(s). Currently using [2019-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/blobServices] used resource type [storageAccounts/blobServices] should use on of the recent API version(s). Currently using [2021-06-01]
/home/runner/work/ResourceModules/ResourceModules/arm/.global/global.module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Storage/storageAccounts/fileServices/shares] used resource type [roleassignments] should use on of the recent API version(s). Currently using [2020-04-01-preview]
…

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr enabled auto-merge (squash) January 6, 2022 18:41
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) January 6, 2022 21:51
MariusStorhaug
MariusStorhaug approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@MariusStorhaug MariusStorhaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@MariusStorhaug MariusStorhaug merged commit b5d27c7 into main Jan 6, 2022
@MariusStorhaug MariusStorhaug deleted the users/alsehr/857_provisioningState branch January 6, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusStorhaug MariusStorhaug MariusStorhaug approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
bug Something isn't working [cat] pipelines category: pipelines
Projects
None yet
Milestone
v 0.4
Development

Successfully merging this pull request may close these issues.

Bug: Failed deployments return as succeeded
2 participants
@AlexanderSehr @MariusStorhaug