This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
fix maxPods deprecation inconsistency #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jackfrancis
force-pushed
the
max-pods-bugs
branch
from
498e9ea
to
5ee4037
Compare
jackfrancis
added a commit
that referenced
this pull request
Apr 12, 2018
* fix maxPods deprecation inconsistency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
KubernetesConfig.MaxPodswas deprecated in practice with the introduction ofkubeletConfig(which allows for direct--max-podsconfig setting), but lots of dangling/inconsistent code was left around.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #2346Special notes for your reviewer:
If applicable:
Release note: