This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Add validation when PodCidr is set in the Azure CNI case. #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JunSun17 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #3562 +/- ##
==========================================
- Coverage 55.48% 55.45% -0.04%
==========================================
Files 105 105
Lines 16036 16038 +2
==========================================
- Hits 8898 8894 -4
- Misses 6386 6392 +6
Partials 752 752 |
PaulCharlton
added a commit
to ElementAnalytics/acs-engine
that referenced
this pull request
Jul 26, 2018
* 'master' of github.com:Azure/acs-engine: Add validation when PodCidr is set in the Azure CNI case. (Azure#3562) update ubuntu image (Azure#3560) add support for 1.10.6 (Azure#3559)
This was referenced Aug 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add validation when PodCidr is set in the Azure CNI case. This should avoid confusion on the Terraform side, otherwise they will see PodCidr is changed and will think a new cluster needs to be created.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixeshashicorp/terraform-provider-azurerm#1648