Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding webhook to prom metrics #125

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Adding webhook to prom metrics #125

merged 3 commits into from
Nov 3, 2023

Conversation

bfoley13
Copy link
Member

@bfoley13 bfoley13 commented Nov 3, 2023

Description

This changes adds mutation/validation webhooks into our current Prometheus metrics.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

  • Unit Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

coveralls commented Nov 3, 2023

Pull Request Test Coverage Report for Build 6749516416

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 22 of 27 (81.48%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 78.548%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/webhook/nginxingress.go 22 27 81.48%
Totals Coverage Status
Change from base Build 6740427943: 0.02%
Covered Lines: 2369
Relevant Lines: 3016

💛 - Coveralls

Copy link
Collaborator

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment

@bfoley13 bfoley13 closed this Nov 3, 2023
@bfoley13 bfoley13 reopened this Nov 3, 2023
@bfoley13 bfoley13 merged commit 39ccfc0 into main Nov 3, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants