add configmaps to watched nic resources #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9502123905Details
💛 - Coveralls |
|
/ok-to-test sha=1799336 |
jaiveerk
requested changes
Nov 28, 2023
| @@ -67,7 +67,8 @@ func NewReconciler(conf *config.Config, mgr ctrl.Manager, defaultIngressClassCon | |||
| if err := nginxIngressControllerReconcilerName.AddToController( | |||
| ctrl.NewControllerManagedBy(mgr). | |||
| For(&approutingv1alpha1.NginxIngressController{}). | |||
| Owns(&appsv1.Deployment{}), | |||
| Owns(&appsv1.Deployment{}). // used to update our status | |||
| Owns(&corev1.ConfigMap{}), // we don't use this to update any statuses but we do want to immediatley overwrite any user changes. it's not supported for users to edit the configmap | |||
|
Is there anyway to defer this until #168 is addressed? |
|
/ok-to-test sha=46937e0 |
|
/ok-to-test sha=e045c7a |
1 similar comment
|
/ok-to-test sha=e045c7a |
|
/ok-to-test sha=c345e00 |
|
/ok-to-test sha=16540c1 |
|
/ok-to-test sha=07cd5d8 |
|
/ok-to-test sha=07cd5d8 |
|
/ok-to-test sha=7d31cb3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Triggers a reconcile on nic resources when a managed configmap is updated.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
E2e and unit tested. This is a core feature of how controller runtime works. It doesn't make sense to try to write a unit test for something already tested in the controller runtime package.
Checklist: