Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OperationInternalBase #1965

Closed
wants to merge 1 commit into from

Conversation

Yao725
Copy link
Member

@Yao725 Yao725 commented Feb 11, 2022

As we provide the customer with the method WaitForCompletion and WaitForCompletionResponse, it might make unnecessary API call and cause serialization failure when the customer sets the parameter waitForCompletion to true but still calls WaitForCompletion by themselves.

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@Yao725
Copy link
Member Author

Yao725 commented Feb 11, 2022

Will be merged after Azure/azure-sdk-for-net#26962

@Yao725 Yao725 closed this Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant