Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format
#3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
requested review from
m-nash,
jsquire and
lirenhe
as code owners
|
@mikeharder what to do about lines like this one?
Convert it to Ubuntu or Windows? I mean, eventually. For now I am tempted to just leave it be. |
konrad-jamrozik
commented
Feb 17, 2023
mikeharder
approved these changes
Feb 18, 2023
Any |
9 tasks
m-nash
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to:
eng/pipelines/build.ymlto azsdk-pool-mms-win-2022-general / MMS2022Compliant #3115Where applicable, update Windows pools used to
azsdk-pool-mms-win-2022-generaland renamevmImageto thewindows-20xxformat.This discussion explains why we chose given
vmImageformat:Mike Harder: 1ES Hosted Pool image name changes
posted in Azure SDK / Engineering System 🛠️ at Wednesday, February 15, 2023 12:10 PM
For further context, please see:
WindowsandUbuntuagent pools to consume2022-Compliantimages azure-sdk-tools#3407