-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FastAPI, htmx, TailwindCSS Web App with Log Analytics template #163
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very awesome sample! Thanks for contributing @tataraba.
@rajeshkamal5050 let's get this tested!
hey @v-xuto can we test this? |
Sure. We will start testing this template https://github.com/tataraba/musicbinder-azd. |
@rajeshkamal5050 We have completed the testing of this template and filed two issues tataraba/musicbinder-azd#2 and tataraba/musicbinder-azd#3. Please review. |
@v-xuto @rajeshkamal5050
Also, added a command in the Dockerfile (for Codespaces) to install the azd CLI. Let me know if there's anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. CC @jongio for any other thoughts in case if I missed anything.
I added comments here: tataraba/musicbinder-azd@91d30c6 |
@jongio Made most of the changes recommended on the commit, with exception to using |
It is up to you to choose if you want to use abbreviations.json, we use it to help us be consistent across all our templates. If you don't want to use it, that is fine. But if you aren't going to use it, then I recommend removing it from your repo. |
@jongio I added |
…musicbinder-template
@jongio abbreviations.json changes looks good to me. I'll merge it to our gallery. Let me know if there're any changes or concerns. |
Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.
If you are submitting a new
azd
template to the galleryFill this out if you want your template to be added to the awesome-azd gallery!
[ x ] Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:
website/src/data/images/
.[ x ] In the PR comment, if you can also add a link to the PR where you made your repo
azd
compatible this will allow us to provide feedback on your template and speed up the review process.No direct PR, but here's a link to the commit that added most of the stuff for
azd
with only one modification made afterwards on the uvicorn command.