Expose some useful type/func to pkg
to be called by external Go modules
#336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes following types/functions to
pkg
to be able to be depended by external Go modules, but with no compatibility guarantees at this moment. This is mainly to be depended by another internal project for now:pkg/conifg
: The configuration typeConfig
pkg/log
: The type and function for setting up loggerpkg/meta
: The main interfaceMeta
and its builder functionBesides, this PR adds following fixes/enhancements:
os.Chdir
in acctestf.Sync
(because of above fix), which is not a right thing to doParallelImport
to allow a list longer than parallelismNonInteractiveModeConfig
andInteractiveModeConfig
to better reason about the configurations given theConfig
is exported, we put (non)interactive related config to these new types on top ofConfig
, which should not be exported to external usersMeta
now acceptscontext.Context