This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add possibility to extract identity providers. #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 14, 2022 12:57
DeagleGross
suggested changes
Jun 20, 2022
src/ArmTemplates/Commands/Configurations/ExtractorConsoleAppConfiguration.cs
Outdated
Show resolved
Hide resolved
src/ArmTemplates/Common/API/Clients/IdentityProviders/IdentityProviderClient.cs
Outdated
Show resolved
Hide resolved
src/ArmTemplates/Common/API/Clients/Abstractions/ApiClientBase.cs
Outdated
Show resolved
Hide resolved
src/ArmTemplates/Common/API/Clients/IdentityProviders/IdentityProviderClient.cs
Outdated
Show resolved
Hide resolved
src/ArmTemplates/Extractor/EntityExtractors/IdentityProviderExtractor.cs
Outdated
Show resolved
Hide resolved
src/ArmTemplates/Common/Templates/IdentityProviders/IdentityProviderType.cs
Show resolved
Hide resolved
DeagleGross
reviewed
Jun 20, 2022
src/ArmTemplates/Common/Templates/IdentityProviders/IdentityProviderType.cs
Outdated
Show resolved
Hide resolved
src/ArmTemplates/Common/Templates/IdentityProviders/IdentityProviderType.cs
Outdated
Show resolved
Hide resolved
DeagleGross
approved these changes
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to extract identity providers.
Introduce new parameter to extract the secrets values from different services. In this PR will be applied only to Identity Provider.
Breaking changes
By default extracted secrets for identityProviders are empty, hence it will break the deployment with error: Secret value should not be empty.
2 options to solve that: