Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

#748 Add GenerateGatewayApiTemplateAsync #751

Merged
merged 2 commits into from
Jun 24, 2022
Merged

#748 Add GenerateGatewayApiTemplateAsync #751

merged 2 commits into from
Jun 24, 2022

Conversation

DSpirit
Copy link
Contributor

@DSpirit DSpirit commented Jun 20, 2022

Added the extraction of the GatewayApi templates to the Extractor.

@DSpirit
#748 Add GenerateGatewayApiTemplateAsync
268a8f3 
Added the extraction of the GatewayApi templates to the Extractor.
@adrianhall adrianhall linked an issue Jun 20, 2022 that may be closed by this pull request
Bug: Gateway API's don't get extracted #748
Closed
@f-alizada
Copy link
Collaborator

Hello @DSpirit.
Thank you very much for the PR fixing the issues.
Could you please resolve the conflicts in the PR?
It seems that this method is already covered by unit tests, so there will be no changes from this point.

@f-alizada f-alizada self-requested a review June 23, 2022 11:07
f-alizada
f-alizada approved these changes Jun 24, 2022
View reviewed changes
Copy link
Collaborator

@f-alizada f-alizada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f-alizada f-alizada merged commit 0f0d419 into Azure:main Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@f-alizada f-alizada f-alizada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Gateway API's don't get extracted
2 participants
@DSpirit @f-alizada