This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Fix: use path.combine instead of string concat #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-alizada
force-pushed
the
fix/path-combine-for-mastertemplate
branch
from
33ec477
to
ddda826
Compare
f-alizada
approved these changes
Nov 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no trailing "/" in the output path, the master-template is sometimes erroneously stored besides the output folder due to the use of
string.Concat(see attached screenshot).For all other templates, Path.Combine is used, so the behavior does not depend on a trailing slash.