Fix style warnings in the webapp extension #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qwordy - The failed checks seem unrelated to my PR. Can you check and let me know if they look related to my changes? |
|
webapp |
|
@yonzhan - All PR validations seem to be failing currently with the same errors. Is this being investigated? |
|
@qwordy could you help with above? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure/azure-cli#16306 |
qwordy
approved these changes
Dec 21, 2020
- This commit primarily fixes the style warnings (azdev style webapp) - upload_source_code parameter list was missing the command param. This commit fixes that. - Another change to functionality is that OneDeploy async deployments don't poll for the operation completion now. This behavior can be toggled for development purposes using the poll_async_deployment_for_debugging flag in code
shrishrirang
force-pushed
the
onedeployimp
branch
from
0b8e11f
to
6f02bb7
Compare
|
hi @qwordy is this PR ok to merge now? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.