-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix style warnings in the webapp extension #2811
Conversation
@qwordy - The failed checks seem unrelated to my PR. Can you check and let me know if they look related to my changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webapp |
@yonzhan - All PR validations seem to be failing currently with the same errors. Is this being investigated? |
@qwordy could you help with above? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure/azure-cli#16306 |
- This commit primarily fixes the style warnings (azdev style webapp) - upload_source_code parameter list was missing the command param. This commit fixes that. - Another change to functionality is that OneDeploy async deployments don't poll for the operation completion now. This behavior can be toggled for development purposes using the poll_async_deployment_for_debugging flag in code
0b8e11f
to
6f02bb7
Compare
hi @qwordy is this PR ok to merge now? |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.