-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vmware] global reach connections #3528
Changes from 4 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,8 @@ rm ..\azure-cli-extensions\src\vmware\azext_vmware\vendored_sdks -Recurse | |
autorest --python --output-folder=..\azure-cli-extensions\src\vmware\azext_vmware\vendored_sdks --use=@autorest/[email protected] --tag=package-2021-06-01 --azure-arm=true --namespace=avs_client --override-client-name=AVSClient specification\vmware\resource-manager\readme.md | ||
``` | ||
It was run from a git clone of [azure-rest-api-specs](https://github.com/Azure/azure-rest-api-specs). | ||
|
||
## Linter | ||
Use [azdev](https://github.com/Azure/azure-cli-dev-tools) to check for linter errors and warnings. | ||
- `azdev style vmware` | ||
- `azdev linter --include-whl-extensions vmware` |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
# Copyright (c) Microsoft Corporation. All rights reserved. | ||
# Licensed under the MIT License. See License.txt in the project root for license information. | ||
# -------------------------------------------------------------------------------------------- | ||
# pylint: disable=line-too-long,too-many-statements | ||
|
||
from azure.cli.core.commands import CliCommandType | ||
from azext_vmware._client_factory import cf_vmware | ||
|
@@ -80,3 +81,9 @@ def load_command_table(self, _): | |
g.custom_show_command('show', 'addon_srm_show') | ||
g.custom_command('update', 'addon_srm_update') | ||
g.custom_command('delete', 'addon_srm_delete') | ||
|
||
with self.command_group('vmware global-reach-connection', vmware_sdk, client_factory=cf_vmware) as g: | ||
g.custom_command('create', 'globalreachconnection_create') | ||
g.custom_command('list', 'globalreachconnection_list') | ||
g.custom_command('delete', 'globalreachconnection_delete') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what about add confirmation for delete command? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm going to assume no. I've asked the PM. The only delete that confirms right now is |
||
g.custom_show_command('show', 'globalreachconnection_show') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there are many features in 3.0, but not released. Do you still have new features to add? If not, recommend to upgrade version in setup.py here. Or will you raise a new PR to upgrade the version in setup.py tp trigger our extension release pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new API is still behind a feature flag in production. After the feature flag is removed, I'll create a new PR to upgrade the version in setup.py to trigger the release.